linux-kernel - Re: [PATCH v4 5/7] rust: alloc: add Vec::retain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nbxnGNgRNc62mejxxJMe3ZrLQ4kO4xaPxi51GVy6iKjA@mail.gmail.com>
Date: Fri, 2 May 2025 23:58:35 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Matthew Maurer <mmaurer@...gle.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	David Gow <davidgow@...gle.com>
Subject: Re: [PATCH v4 5/7] rust: alloc: add Vec::retain

On Thu, May 1, 2025 at 1:30 PM Danilo Krummrich <dakr@...nel.org> wrote:
>
> I really like the way doctests implement the assert macros and how they appear
> in the kernel log compared to panics through the "real" assert ones, unwraps,
> etc.
>
> I also think that avoiding things that directly panic in doctests (i.e. example
> code) is the correct thing to do. For KUnit tests it's probably less important,
> since they don't directly serve as sample code.

I hadn't seen these earlier messages -- thanks, I am glad people like
the doctests support :)

Yeah, doing the same for `#[test]`s was planned (see PR), but we
decided to merge roughly what we had from the original author and then
build on top of that (Cc David).

Anyway, I sent it -- hopefully it will mean more people writing lots of tests!

    https://lore.kernel.org/rust-for-linux/20250502215133.1923676-1-ojeda@kernel.org/

Cheers,
Miguel