linux-kernel - Re: Re: [PATCH v4 5/7] rust: alloc: add Vec::retain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250502141314.1661057-1-ojeda@kernel.org>
Date: Fri,  2 May 2025 16:13:14 +0200
From: Miguel Ojeda <ojeda@...nel.org>
To: dakr@...nel.org
Cc: David Gow <davidgow@...gle.com>,
	aliceryhl@...gle.com,
	linux-kernel@...r.kernel.org,
	mmaurer@...gle.com,
	rust-for-linux@...r.kernel.org,
	Miguel Ojeda <ojeda@...nel.org>
Subject: Re: Re: [PATCH v4 5/7] rust: alloc: add Vec::retain

On Wed, 30 Apr 2025 18:26:05 +0200 Danilo Krummrich <dakr@...nel.org> wrote:
>
> Can we have this return a Result, like doctests can do?
>
> Don't we have macros around kunit_assert!() and kunit_assert_eq() outside of
> doctests (i.e. dedicated kunit tests)?

The initial KUnit `#[test]` support that landed was very basic:

    https://lore.kernel.org/rust-for-linux/20250330170535.546869-1-ojeda@kernel.org/

The missing `assert*!`s support is definitely annoying. I took a quick look,
and it is not too bad to add the support. The `Result` is then easy on top too.

So I will send the support for both already since I suspect others will hit this
quite soon.

I hope that helps.

Cheers,
Miguel