linux-kernel - Re: [PATCH RESEND] drm/amd/display: adds kernel-doc comment for dc_stream_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83eae1ce-ead2-47c9-a636-755a5207a6be@amd.com>
Date: Fri, 2 May 2025 16:25:27 -0600
From: Alex Hung <alex.hung@....com>
To: James Flowers <bold.zone2373@...tmail.com>, harry.wentland@....com,
 sunpeng.li@....com, siqueira@...lia.com, alexander.deucher@....com,
 christian.koenig@....com, airlied@...il.com, simona@...ll.ch,
 skhan@...uxfoundation.org
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH RESEND] drm/amd/display: adds kernel-doc comment for
 dc_stream_remove_writeback()

Hi James,

checkpatch reports the following warning and error

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#18:
Adds a kernel-doc for externally linked dc_stream_remove_writeback() 
function.

ERROR: trailing whitespace
#39: FILE: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:561:
+ * Return: returns true on success, false otherwise. $

total: 1 errors, 1 warnings, 14 lines checked


On 4/30/25 23:56, James Flowers wrote:
> Adds a kernel-doc for externally linked dc_stream_remove_writeback() function.
> 
> Signed-off-by: James Flowers <bold.zone2373@...tmail.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index 0478dd856d8c..060ee6c3fc2e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -552,6 +552,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
>   	return true;
>   }
>   
> +/**
> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
> + * @dc: Display core control structure.
> + * @stream: Display core stream state.
> + * @dwb_pipe_inst: Display writeback pipe.
> + *
> + * Return: returns true on success, false otherwise.
> + */
>   bool dc_stream_remove_writeback(struct dc *dc,
>   		struct dc_stream_state *stream,
>   		uint32_t dwb_pipe_inst)