linux-kernel - Re: [PATCH RESEND] drm/amd/display: adds kernel-doc comment for dc_stream_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <e2119599-6641-4327-b3eb-d49c128e8513@app.fastmail.com>
Date: Sat, 03 May 2025 11:52:16 -0700
From: James <bold.zone2373@...tmail.com>
To: "Alex Hung" <alex.hung@....com>,
 "Harry Wentland" <harry.wentland@....com>, sunpeng.li@....com,
 "Rodrigo Siqueira" <siqueira@...lia.com>,
 "Alex Deucher" <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 airlied@...il.com, simona@...ll.ch, "Shuah Khan" <skhan@...uxfoundation.org>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH RESEND] drm/amd/display: adds kernel-doc comment for
 dc_stream_remove_writeback()


On Fri, May 2, 2025, at 3:25 PM, Alex Hung wrote:
> Hi James,
>
> checkpatch reports the following warning and error
>
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
> description?)
> #18:
> Adds a kernel-doc for externally linked dc_stream_remove_writeback() 
> function.
>
> ERROR: trailing whitespace
> #39: FILE: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:561:
> + * Return: returns true on success, false otherwise. $
>
> total: 1 errors, 1 warnings, 14 lines checked
>
>
> On 4/30/25 23:56, James Flowers wrote:
>> Adds a kernel-doc for externally linked dc_stream_remove_writeback() function.
>> 
>> Signed-off-by: James Flowers <bold.zone2373@...tmail.com>
>> ---
>>   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>> index 0478dd856d8c..060ee6c3fc2e 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>> @@ -552,6 +552,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
>>   	return true;
>>   }
>>   
>> +/**
>> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
>> + * @dc: Display core control structure.
>> + * @stream: Display core stream state.
>> + * @dwb_pipe_inst: Display writeback pipe.
>> + *
>> + * Return: returns true on success, false otherwise.
>> + */
>>   bool dc_stream_remove_writeback(struct dc *dc,
>>   		struct dc_stream_state *stream,
>>   		uint32_t dwb_pipe_inst)

Thank you Alex, and sorry about that. I will correct those issues and submit a new version.