[<prev] [next>] [day] [month] [year] [list]
Message-ID: <aBSEwag_ducqOwy7@stanley.mountain>
Date: Fri, 2 May 2025 11:39:29 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Keguang Zhang <keguang.zhang@...il.com>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>, linux-mips@...r.kernel.org,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [PATCH next] mtd: rawnand: loongson1: Fix error code in
ls1x_nand_dma_transfer()
The "desc" variable is NULL and PTR_ERR(NULL) is zero/success. Return
a negative error code instead.
Fixes: d2d10ede04b1 ("mtd: rawnand: Add Loongson-1 NAND Controller Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
It's hard to know what the patch prefix should be here. Ideally when we
add a new driver we would use the patch prefix for the driver.
Tired: subsystem: Add driver XXX
Wired: subsystem: XXX: Add driver for XXX
drivers/mtd/nand/raw/loongson1-nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/loongson1-nand-controller.c b/drivers/mtd/nand/raw/loongson1-nand-controller.c
index 6a369b1c7d86..8754bb4f8b56 100644
--- a/drivers/mtd/nand/raw/loongson1-nand-controller.c
+++ b/drivers/mtd/nand/raw/loongson1-nand-controller.c
@@ -371,7 +371,7 @@ static int ls1x_nand_dma_transfer(struct ls1x_nand_host *host, struct ls1x_nand_
desc = dmaengine_prep_slave_single(chan, dma_addr, op->len, xfer_dir, DMA_PREP_INTERRUPT);
if (!desc) {
dev_err(dev, "failed to prepare DMA descriptor\n");
- ret = PTR_ERR(desc);
+ ret = -ENOMEM;
goto err;
}
desc->callback = ls1x_nand_dma_callback;
--
2.47.2
Powered by blists - more mailing lists