linux-kernel - Re: [PATCH next] mtd: rawnand: loongson1: Fix error code in ls1x_nand_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhJPsUZz2kwMyWPDrc_ktb5O6ECcAyO1OrXXVWh9yvkrKRidg@mail.gmail.com>
Date: Tue, 6 May 2025 17:16:03 +0800
From: Keguang Zhang <keguang.zhang@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, 
	Vignesh Raghavendra <vigneshr@...com>, linux-mips@...r.kernel.org, linux-mtd@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] mtd: rawnand: loongson1: Fix error code in ls1x_nand_dma_transfer()

On Fri, May 2, 2025 at 4:39 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The "desc" variable is NULL and PTR_ERR(NULL) is zero/success.  Return
> a negative error code instead.
>
> Fixes: d2d10ede04b1 ("mtd: rawnand: Add Loongson-1 NAND Controller Driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> It's hard to know what the patch prefix should be here.  Ideally when we
> add a new driver we would use the patch prefix for the driver.
>
> Tired: subsystem: Add driver XXX
> Wired: subsystem: XXX: Add driver for XXX
>
>  drivers/mtd/nand/raw/loongson1-nand-controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/loongson1-nand-controller.c b/drivers/mtd/nand/raw/loongson1-nand-controller.c
> index 6a369b1c7d86..8754bb4f8b56 100644
> --- a/drivers/mtd/nand/raw/loongson1-nand-controller.c
> +++ b/drivers/mtd/nand/raw/loongson1-nand-controller.c
> @@ -371,7 +371,7 @@ static int ls1x_nand_dma_transfer(struct ls1x_nand_host *host, struct ls1x_nand_
>         desc = dmaengine_prep_slave_single(chan, dma_addr, op->len, xfer_dir, DMA_PREP_INTERRUPT);
>         if (!desc) {
>                 dev_err(dev, "failed to prepare DMA descriptor\n");
> -               ret = PTR_ERR(desc);
> +               ret = -ENOMEM;

Thank you for fixing this issue.
However, I believe -EIO is more appropriate than -ENOMEM, since
dmaengine_prep_slave_single() can return errors other than -ENOMEM.

>                 goto err;
>         }
>         desc->callback = ls1x_nand_dma_callback;
> --
> 2.47.2
>


-- 
Best regards,

Keguang Zhang