linux-kernel - Re: [PATCH] counter: interrupt-cnt: Convert atomic_t -> atomic_long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91c00e75bc25267d57863494d638f0a43e499ac4.camel@siemens.com>
Date: Fri, 2 May 2025 09:24:18 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC: "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"wbg@...nel.org" <wbg@...nel.org>
Subject: Re: [PATCH] counter: interrupt-cnt: Convert atomic_t -> atomic_long_t

Dear maintainers,

On Mon, 2025-03-31 at 17:22 +0200, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> 
> Convert the internal counter type to atomic_long_t, which:
> - doesn't change much for existing in-tree users as they are 32-bit anyway
>   (stm32/i.MX6)
> - doesn't introduce performace penalty on 32-bit platforms
> - provides 64-bit resolution on 64-bit platforms with virtually no
>   preformance penalty
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

I've noticed that the patch has been marked as "Changes Requested" in
the patchwork, could it be a mistake? Because I never received any
change request.

> ---
>  drivers/counter/interrupt-cnt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> index 949598d51575a..8df5457b0a076 100644
> --- a/drivers/counter/interrupt-cnt.c
> +++ b/drivers/counter/interrupt-cnt.c
> @@ -15,7 +15,7 @@
>  #define INTERRUPT_CNT_NAME "interrupt-cnt"
>  
>  struct interrupt_cnt_priv {
> -	atomic_t count;
> +	atomic_long_t count;
>  	struct gpio_desc *gpio;
>  	int irq;
>  	bool enabled;
> @@ -29,7 +29,7 @@ static irqreturn_t interrupt_cnt_isr(int irq, void *dev_id)
>  	struct counter_device *counter = dev_id;
>  	struct interrupt_cnt_priv *priv = counter_priv(counter);
>  
> -	atomic_inc(&priv->count);
> +	atomic_long_inc(&priv->count);
>  
>  	counter_push_event(counter, COUNTER_EVENT_CHANGE_OF_STATE, 0);
>  
> @@ -89,7 +89,7 @@ static int interrupt_cnt_read(struct counter_device *counter,
>  {
>  	struct interrupt_cnt_priv *priv = counter_priv(counter);
>  
> -	*val = atomic_read(&priv->count);
> +	*val = atomic_long_read(&priv->count);
>  
>  	return 0;
>  }
> @@ -102,7 +102,7 @@ static int interrupt_cnt_write(struct counter_device *counter,
>  	if (val != (typeof(priv->count.counter))val)
>  		return -ERANGE;
>  
> -	atomic_set(&priv->count, val);
> +	atomic_long_set(&priv->count, val);
>  
>  	return 0;
>  }

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com