linux-kernel - Re: [PATCH v1 2/4] arm64: dts: ti: k3-am62x: Add required voltage supplies for IMX219

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19dd4cc6-c110-4c2d-b725-5e7bd1a4226c@ti.com>
Date: Fri, 2 May 2025 16:39:23 +0530
From: "Donadkar, Rishikesh" <r-donadkar@...com>
To: Devarsh Thakkar <devarsht@...com>, <nm@...com>, <vigneshr@...com>
CC: <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <vaishnav.a@...com>, <y-abhilashchandra@...com>,
        <s-jain1@...com>, <jai.luthra@...ux.dev>,
        <jai.luthra@...asonboard.com>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <imx@...ts.linux.dev>
Subject: Re: [PATCH v1 2/4] arm64: dts: ti: k3-am62x: Add required voltage
 supplies for IMX219


On 02-05-2025 13:45, Devarsh Thakkar wrote:
> On 29/04/25 21:11, Rishikesh Donadkar wrote:
>> The device tree overlay for the IMX219 sensor requires three voltage
>> supplies to be defined: VANA (analog), VDIG (digital core), and VDDL
>> (digital I/O).
>>
>> Add the corresponding voltage supply definitions to avoid dtbs_check
>> warnings.
>>
> On a side-note device-tree overlay requiring these voltages is an
> implied reason, it's mainly because the schematics mention that and
> bindings want to capture same topography in device-tree too.
>
> So maybe good to mention that and share schematic link too in commit
> message :
>
> https://datasheets.raspberrypi.com/camera/camera-module-2-schematics.pdf
>
> With these changes, feel free to add,
>
> Reviewed-by: Devarsh Thakkar <devarsht@...com>
Hi Devarsh, Thanks for the review. I will do this in the next revision.
>
> Regards
> Devarsh
>
>> Signed-off-by: Rishikesh Donadkar <r-donadkar@...com>
>> ---
>>   .../boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso  | 31 +++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
>> index dd090813a32d6..149c59c071823 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
>> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
>> @@ -15,6 +15,33 @@ clk_imx219_fixed: imx219-xclk {
>>   		#clock-cells = <0>;
>>   		clock-frequency = <24000000>;
>>   	};
>> +
>> +	reg_2p8v: regulator-2p8v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "2P8V";
>> +		regulator-min-microvolt = <2800000>;
>> +		regulator-max-microvolt = <2800000>;
>> +		vin-supply = <&vcc_3v3_sys>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	reg_1p8v: regulator-1p8v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "1P8V";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		vin-supply = <&vcc_3v3_sys>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	reg_1p2v: regulator-1p2v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "1P2V";
>> +		regulator-min-microvolt = <1200000>;
>> +		regulator-max-microvolt = <1200000>;
>> +		vin-supply = <&vcc_3v3_sys>;
>> +		regulator-always-on;
>> +	};
>>   };
>>   
>>   &main_i2c2 {
>> @@ -40,6 +67,10 @@ ov5640: camera@10 {
>>   
>>   				clocks = <&clk_imx219_fixed>;
>>   
>> +				VANA-supply = <&reg_2p8v>;
>> +				VDIG-supply = <&reg_1p8v>;
>> +				VDDL-supply = <&reg_1p2v>;
>> +
>>   				reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
>>   
>>   				port {