linux-kernel - Re: [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable Ethernet boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250502120053.zvtxmjuybetlk2er@manhood>
Date: Fri, 2 May 2025 07:00:53 -0500
From: Nishanth Menon <nm@...com>
To: "Vankar, Chintan" <c-vankar@...com>
CC: Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, Tero Kristo
	<kristo@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>, <srk@...com>,
        <s-vadapalli@...com>, <danishanwar@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Roger
 Quadros <rogerq@...nel.org>
Subject: Re: [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add
 bootph-all property to enable Ethernet boot

On 11:18-20250430, Vankar, Chintan wrote:
> Hello Nishanth,
> 
> On 4/29/2025 4:57 PM, Nishanth Menon wrote:
> > On 12:56-20250429, Chintan Vankar wrote:
> > > Ethernet boot requires CPSW nodes to be present starting from R5 SPL
> > > stage. Add bootph-all property to required nodes to enable Ethernet boot
> > > for AM62P5-SK and J722S-EVM.
> > > 
> > > Reviewed-by: Roger Quadros <rogerq@...nel.org>
> > > Signed-off-by: Chintan Vankar <c-vankar@...com>
> > > ---
> > > 
> > > Link to v3:
> > > https://lore.kernel.org/r/20250425051055.2393301-3-c-vankar@ti.com/
> > > 
> > > Changes from v3 to v4:
> > > - No changes.
> > > 
> > >   arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
> > 
> > Please notice that we have the same problem[1] here as well.
> > 
> > [1] https://lore.kernel.org/all/20250425212427.vvyocc4mmne5g3vq@vividly/
> 
> I have added "bootph-all" property in the common file of J722S-EVM and
> AM62P5-SK since we are enabling Ethernet boot for both the boards. Are
> you referring to move the nodes I have added in
> "k3-am62p-j722s-common-main.dtsi" to respective board files,
> "k3-am62p5-sk.dts" and "k3-j722s-evm.dts".

Yes, bootph properties should not be done in SoC dtsi files unless it is
mandatory for all boot-modes and all boards. That is not the case here
as well. This is the exact comment provided in the previous version for
patch 1 with the expectation that you'd apply it to the rest of your
series.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D