linux-kernel - Re: [PATCH] watchdog: Fix the SOFTLOCKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90953737-7c8c-4868-984d-30430b5aefaa@linux.ibm.com>
Date: Fri, 2 May 2025 17:30:25 +0530
From: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
To: "Nysal Jan K.A." <nysal@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc: luogengkun@...weicloud.com, dianders@...omium.org,
        joel.granados@...nel.org, song@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] watchdog: Fix the SOFTLOCKUP_DETECTOR=n case


On 02/05/25 4:41 pm, Nysal Jan K.A. wrote:
> Update watchdog_thresh when SOFTLOCKUP_DETECTOR=n.
> Additionally fix a build failure in this case as well.
>
> Fixes: 0bff3dababb07 ("watchdog: fix watchdog may detect false positive of softlockup")
> Reported-by: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
> Closes: https://lore.kernel.org/all/339e2b3e-c7ee-418f-a84c-9c6360dc570b@linux.ibm.com
> Signed-off-by: Nysal Jan K.A. <nysal@...ux.ibm.com>
> ---
> The "Fixes:" SHA1 points to the commit in mm-nonmm-unstable and will need updating
>
>   kernel/watchdog.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 80d1a1dae27..2d283e92be5 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -923,10 +923,12 @@ static __init void lockup_detector_setup(void)
>   }
>   
>   #else /* CONFIG_SOFTLOCKUP_DETECTOR */
> -static void __lockup_detector_reconfigure(void)
> +static void __lockup_detector_reconfigure(bool thresh_changed)
>   {
>   	cpus_read_lock();
>   	watchdog_hardlockup_stop();
> +	if (thresh_changed)
> +		watchdog_thresh = READ_ONCE(watchdog_thresh_next);
>   	lockup_detector_update_enable();
>   	watchdog_hardlockup_start();
>   	cpus_read_unlock();


Tested this patch, and with this, build is successful. Hence,


Tested-by: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>


Regards,

Venkat.