linux-kernel - Re: [PATCH 2/3] selftests/timens: Make run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7868a82f-3da9-4a25-8182-4634b808ec53@collabora.com>
Date: Fri, 2 May 2025 17:13:51 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>
Cc: usama.anjum@...labora.com, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] selftests/timens: Make run_tests() functions static

On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> These functions are never used outside their defining compilation unit and
> can be made static.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/timens/clock_nanosleep.c | 2 +-
>  tools/testing/selftests/timens/timer.c           | 2 +-
>  tools/testing/selftests/timens/timerfd.c         | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/timens/clock_nanosleep.c b/tools/testing/selftests/timens/clock_nanosleep.c
> index 346bff3d128dfa8c8c743cc2eba74917994bb2f7..5cc0010e85ff00e00c89940a82268994a1769873 100644
> --- a/tools/testing/selftests/timens/clock_nanosleep.c
> +++ b/tools/testing/selftests/timens/clock_nanosleep.c
> @@ -38,7 +38,7 @@ void *call_nanosleep(void *_args)
>  	return NULL;
>  }
>  
> -int run_test(int clockid, int abs)
> +static int run_test(int clockid, int abs)
>  {
>  	struct timespec now = {}, rem;
>  	struct thread_args args = { .now = &now, .rem = &rem, .clockid = clockid};
> diff --git a/tools/testing/selftests/timens/timer.c b/tools/testing/selftests/timens/timer.c
> index 51babe63e233bdaaef35c1cafbcb5b5cc91c021e..79543ceb2c0f97fdd638271a762c97a8b19d9a4a 100644
> --- a/tools/testing/selftests/timens/timer.c
> +++ b/tools/testing/selftests/timens/timer.c
> @@ -15,7 +15,7 @@
>  #include "log.h"
>  #include "timens.h"
>  
> -int run_test(int clockid, struct timespec now)
> +static int run_test(int clockid, struct timespec now)
>  {
>  	struct itimerspec new_value;
>  	long long elapsed;
> diff --git a/tools/testing/selftests/timens/timerfd.c b/tools/testing/selftests/timens/timerfd.c
> index e58bc8b64ce2738dccb8c2a2c88e592c237b55d5..d6adf66bd8df064f5b76ccc265c13217d7a53f5b 100644
> --- a/tools/testing/selftests/timens/timerfd.c
> +++ b/tools/testing/selftests/timens/timerfd.c
> @@ -22,7 +22,7 @@ static int tclock_gettime(clock_t clockid, struct timespec *now)
>  	return clock_gettime(clockid, now);
>  }
>  
> -int run_test(int clockid, struct timespec now)
> +static int run_test(int clockid, struct timespec now)
>  {
>  	struct itimerspec new_value;
>  	long long elapsed;
> 


-- 
Regards,
Usama