linux-kernel - Re: [PATCH 3/3] selftests/timens: timerfd: Use correct clockid type in tclock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5203d87f-a098-4f76-81cb-4966181de4eb@collabora.com>
Date: Fri, 2 May 2025 17:14:02 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>
Cc: usama.anjum@...labora.com, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] selftests/timens: timerfd: Use correct clockid type
 in tclock_gettime()

On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> tclock_gettime() is a wrapper around clock_gettime().
> The first parameter of clock_gettime() is of type "clockid_t",
> not "clock_t".
> 
> Use the correct type instead.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/timens/timerfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timens/timerfd.c b/tools/testing/selftests/timens/timerfd.c
> index d6adf66bd8df064f5b76ccc265c13217d7a53f5b..402e2e4155450d946796b8297a8be85f93cea16f 100644
> --- a/tools/testing/selftests/timens/timerfd.c
> +++ b/tools/testing/selftests/timens/timerfd.c
> @@ -15,7 +15,7 @@
>  #include "log.h"
>  #include "timens.h"
>  
> -static int tclock_gettime(clock_t clockid, struct timespec *now)
> +static int tclock_gettime(clockid_t clockid, struct timespec *now)
>  {
>  	if (clockid == CLOCK_BOOTTIME_ALARM)
>  		clockid = CLOCK_BOOTTIME;
> 


-- 
Regards,
Usama