linux-kernel - Re: [PATCH 1/3] selftests/timens: Print TAP headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5609c6de-e5cf-4f6d-8412-71149fae2580@linuxfoundation.org>
Date: Wed, 7 May 2025 15:06:16 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>, "Bird, Timothy" <Tim.Bird@...y.com>
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] selftests/timens: Print TAP headers

On 5/2/25 06:03, Thomas Weißschuh wrote:
> The TAP specification requires that the output begins with a header line.
> These headers lines are missing in the timens tests.
> 
> Print such a line.

There is no cover letter for this - so I will respond to the first
patch. The TAP information is added by the kselftest wrapper if
you were to run the test using ksefltest.

The following will add the TAP header or if you use make kselftest
command from the main Makefile.

make -C timens run_tests

cd timens; make run_tests (will also add TAP header)

The only time you won't see the TAP headers is when you run the test
from the test directory just as a command. Is this what you need
to do? I would rather not see TAP headers added to invidual tests
unless there is a good reason for it.

The problem with adding TAP headers is two-fold:

1. It becomes hard to read the ouptput if test is run using
    the framework a. make -C timens run_tests b. cd timens; make run_tests
2. These headers become bested and TAP doesn't like nested TAP headers.
    My undestansing is parses will have problems.

I am adding Tim Bird to the discussion.

Tim, is this still an issue? Are nested TAP headers still a problem.

Even if they aren't there is the issue of multiple TAP headers for
each test when we run the test using framework.

thanks,
-- Shuah