linux-kernel - Re: [PATCH 0/4] selftests/mm/uffd: refactor global variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D9LO37W7M7YJ.2R0GAINJRE55C@google.com>
Date: Fri, 02 May 2025 12:18:13 +0000
From: Brendan Jackman <jackmanb@...gle.com>
To: Ujwal Kundur <ujwal.kundur@...il.com>, <akpm@...ux-foundation.org>, 
	<peterx@...hat.com>, <shuah@...nel.org>
Cc: <linux-mm@...ck.org>, <linux-kselftest@...r.kernel.org>, 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] selftests/mm/uffd: refactor global variables

On Thu May 1, 2025 at 4:38 PM UTC, Ujwal Kundur wrote:
> This patchset refactors non-composite global variables into a common
> struct that can be initialized and passed around per-test instead of
> relying on the presence of global variables.
>
> This allows:
> - Better encapsulation
> - Debugging becomes easier -- local variable state can be viewed per
>   stack frame, and we can more easily reason about the variable
>   mutations
>
> Patch 1 needs to be applied first and can be followed by any of the
> other patches.
> I've ensured that the tests are passing locally (or atleast have the
> same output as the code on master).
>
> Ujwal Kundur (4):
>   selftests/mm/uffd: Refactor non-composite global vars into struct
>   selftests/mm/uffd: Swap global vars with global test options
>   selftests/mm/uffd: Swap global variables with global test opts
>   selftests/mm/uffd: Swap global variables with global test opts

I tested this using this script:

https://github.com/bjackman/linux/blob/523e40a88fac34b17f49614dfb24fd5e18e63685/.github/scripts/run_local.sh

After manually enabling the userfaultfd tests (I disable them in my
crappy CI thing as they are flaky):

https://github.com/bjackman/linux/blob/523e40a88fac34b17f49614dfb24fd5e18e63685/.github/scripts/test.guest.sh#L15

So

Tested-by: Brendan Jackman <jackmanb@...gle.com>