linux-kernel - Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+i-1C1x2TenH-WxkUnkx3-5XpkXOMMmZQTCBV3sHDV8WWN=oA@mail.gmail.com>
Date: Fri, 2 May 2025 14:28:11 +0200
From: Brendan Jackman <jackmanb@...gle.com>
To: Ujwal Kundur <ujwal.kundur@...il.com>, akpm@...ux-foundation.org, peterx@...hat.com, 
	shuah@...nel.org
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars
 into struct

On Fri, 2 May 2025 at 14:16, Brendan Jackman <jackmanb@...gle.com> wrote:
> Little bit of indentation mess here
>
> I don't understand this code but since I was hurt by these global
> variables I had a look over the diff anyway, it LGTM (aside from the
> formatting nits), thanks.
>
> Reviewed-by: Brendan Jackman <jackmanb@...gle.com>

Wait sorry, actually, this deletes the global vars before it deletes
the references to them. That's gonna be a real pain for bisections,
please can you restructure the series to prevent intervening build
failures?

(I.e. if I apply just 1/4, the selftests don't compile).