linux-kernel - Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALkFLLJ4CYRFuyR8sHi5Ah06QD_fDuF9v5eCyG7Xh+2kHPVzEg@mail.gmail.com>
Date: Sat, 3 May 2025 23:46:26 +0530
From: Ujwal Kundur <ujwal.kundur@...il.com>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: akpm@...ux-foundation.org, peterx@...hat.com, shuah@...nel.org, 
	linux-mm@...ck.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars
 into struct

Thanks for the review and testing!

I'll push a V2 with the indentation fixes soon.

> this deletes the global vars before it deletes
> the references to them. That's gonna be a real pain for bisections,
> please can you restructure the series to prevent intervening build
> failures?
> (i.e. if I apply just 1/4, the selftests don't compile).

Could you help me understand this better? The selftests don't compile
either way if both 1 and 2/3/4 aren't applied at the same time.

--- Ujwal.