linux-kernel - Re: [PATCH v7 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1BC3B1AB-98D8-42CC-9CD7-2770BE19228C@gmail.com>
Date: Sat, 03 May 2025 11:05:07 -0700
From: "Derek J. Clark" <derekjohn.clark@...il.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Armin Wolf <W_Armin@....de>, Jonathan Corbet <corbet@....net>,
 Mario Limonciello <superm1@...nel.org>, Luke Jones <luke@...nes.dev>,
 Xino Ni <nijs1@...ovo.com>, Zhixin Zhang <zhangzx36@...ovo.com>,
 Mia Shao <shaohz1@...ovo.com>, Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 "Cody T . -H . Chiu" <codyit@...il.com>, John Martens <johnfanv2@...il.com>,
 platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

On May 3, 2025 2:42:38 AM PDT, ALOK TIWARI <alok.a.tiwari@...cle.com> wrote:
>Hi Derek,
>
>Thanks for your patch.
>
>On 03-05-2025 05:31, Derek J. Clark wrote:
>> +	attribute_id =
>> +		FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) |
>> +		FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) |
>> +		FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, LWMI_GZ_THERMAL_MODE_CUSTOM) |
>> +		FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id);
>> +
>> +	//capdata = devm_kzalloc(&priv->wdev->dev, sizeof(*capdata), GFP_KERNEL);
>> +	//if (!capdata)
>> +	//	return -ENOMEM;
>
>remove this dead code
>

Woops... thanks.

Are you planning on reviewing the other 4 patches?  If not I'll fix these up and send an update today.

Cheers, 
Derek

>> +
>> +	ret = lwmi_cd01_get_data(priv->cd01_list, attribute_id, &capdata);
>> +	if (ret)
>> +		return ret;
>
>
>Reviewed-by: Alok Tiwari <alok.a.tiwari@...cle.com>
>
>Thanks,
>Alok

- Derek