linux-kernel - Re: [PATCH 5/7] selftests: vDSO: vdso_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7365a45-6064-4ace-81da-ce46ea5a6c91@collabora.com>
Date: Fri, 2 May 2025 18:46:28 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Vincenzo Frascino <vincenzo.frascino@....com>, Shuah Khan
 <shuah@...nel.org>, "Jason A. Donenfeld" <Jason@...c4.com>
Cc: usama.anjum@...labora.com, Shuah Khan <skhan@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 5/7] selftests: vDSO: vdso_test_getrandom: Drop some dead
 code

On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> vgetrandom_put_state() and the variable ret in kselftest() are never used.
> 
> Drop the dead code.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/vDSO/vdso_test_getrandom.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index f36e50f372f935e6d4da3175c81e210653bdce1d..b0e0d664508a38d6dde9df0a61ec8198ee928a17 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -100,15 +100,6 @@ static void *vgetrandom_get_state(void)
>  	return state;
>  }
>  
> -static void vgetrandom_put_state(void *state)
> -{
> -	if (!state)
> -		return;
> -	pthread_mutex_lock(&vgrnd.lock);
> -	vgrnd.states[vgrnd.len++] = state;
> -	pthread_mutex_unlock(&vgrnd.lock);
> -}
> -
>  static void vgetrandom_init(void)
>  {
>  	const char *version = versions[VDSO_VERSION];
> @@ -264,7 +255,7 @@ static void kselftest(void)
>  	}
>  	for (;;) {
>  		struct ptrace_syscall_info info = { 0 };
> -		int status, ret;
> +		int status;
>  		ksft_assert(waitpid(child, &status, 0) >= 0);
>  		if (WIFEXITED(status)) {
>  			ksft_assert(WEXITSTATUS(status) == 0);
> 

-- 
Regards,
Usama