linux-kernel - Re: [PATCH 6/7] selftests: vDSO: vdso_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36bb6e78-1db9-4dad-a2ef-7e860ead30e4@collabora.com>
Date: Fri, 2 May 2025 18:48:03 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Vincenzo Frascino <vincenzo.frascino@....com>, Shuah Khan
 <shuah@...nel.org>, "Jason A. Donenfeld" <Jason@...c4.com>
Cc: usama.anjum@...labora.com, Shuah Khan <skhan@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 6/7] selftests: vDSO: vdso_test_getrandom: Always print
 TAP header

On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> The TAP specification requires that the output begins with a header line.
> If vgetrandom_init() fails and skips the test, that header line is missing.
> 
> Call vgetrandom_init() after ksft_print_header().
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/vDSO/vdso_test_getrandom.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index b0e0d664508a38d6dde9df0a61ec8198ee928a17..01892d8e65d754d0353f7df2b63910d5be8cd1bc 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -232,6 +232,7 @@ static void kselftest(void)
>  	pid_t child;
>  
>  	ksft_print_header();
> +	vgetrandom_init();
>  	ksft_set_plan(2);
>  
>  	for (size_t i = 0; i < 1000; ++i) {
> @@ -285,8 +286,6 @@ static void usage(const char *argv0)
>  
>  int main(int argc, char *argv[])
>  {
> -	vgetrandom_init();
> -
>  	if (argc == 1) {
>  		kselftest();
>  		return 0;
> @@ -296,6 +295,9 @@ int main(int argc, char *argv[])
>  		usage(argv[0]);
>  		return 1;
>  	}
> +
> +	vgetrandom_init();
> +
>  	if (!strcmp(argv[1], "bench-single"))
>  		bench_single();
>  	else if (!strcmp(argv[1], "bench-multi"))
> 


-- 
Regards,
Usama