lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <27d03a23-ec61-4dbe-b9ca-1c0cf3d52d29@collabora.com>
Date: Fri, 2 May 2025 18:49:01 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Vincenzo Frascino <vincenzo.frascino@....com>, Shuah Khan
 <shuah@...nel.org>, "Jason A. Donenfeld" <Jason@...c4.com>
Cc: usama.anjum@...labora.com, Shuah Khan <skhan@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 7/7] selftests: vDSO: vdso_config: Avoid
 -Wunused-variables

On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> Not all users of this header make use of all its variables.
> For example vdso_test_correctness.c does not use "versions":
> 
> In file included from vdso_test_correctness.c:22:
> vdso_config.h:61:20: warning: ‘versions’ defined but not used [-Wunused-variable]
>    61 | static const char *versions[7] = {
>       |                    ^~~~~~~~
> 
> Avoid those warnings through attribute((unused)).
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/vDSO/vdso_config.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_config.h b/tools/testing/selftests/vDSO/vdso_config.h
> index 722260f9756198956f0dfccced907284b6851e76..5fdd0f36233742bc47ae79f23d2cfae5a0f56dee 100644
> --- a/tools/testing/selftests/vDSO/vdso_config.h
> +++ b/tools/testing/selftests/vDSO/vdso_config.h
> @@ -58,6 +58,7 @@
>  #define VDSO_NAMES		1
>  #endif
>  
> +__attribute__((unused))
>  static const char *versions[7] = {
>  	"LINUX_2.6",
>  	"LINUX_2.6.15",
> @@ -68,6 +69,7 @@ static const char *versions[7] = {
>  	"LINUX_5.10"
>  };
>  
> +__attribute__((unused))
>  static const char *names[2][7] = {
>  	{
>  		"__kernel_gettimeofday",
> 


-- 
Regards,
Usama

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ