linux-kernel - Re: [PATCH] locking/lockdep: Prevent abuse of lockdep subclass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBer8jsN9T9r_bI0@Mac.home>
Date: Sun, 4 May 2025 11:03:30 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Waiman Long <longman@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Will Deacon <will.deacon@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] locking/lockdep: Prevent abuse of lockdep subclass

On Wed, Apr 09, 2025 at 10:37:51AM -0400, Waiman Long wrote:
> As I have seen code trying to use a subclass value >=
> MAX_LOCKDEP_SUBCLASSES (8), add a DEBUG_LOCKS_WARN_ON() statement to
> notify the users that such a large value is not allowed.
> 
> Signed-off-by: Waiman Long <longman@...hat.com>

Queued for 6.16, thanks!

Regards,
Boqun

> ---
>  kernel/locking/lockdep.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 58d78a33ac65..3fb79d8fecdf 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -5101,6 +5101,9 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
>  		lockevent_inc(lockdep_nocheck);
>  	}
>  
> +	if (DEBUG_LOCKS_WARN_ON(subclass >= MAX_LOCKDEP_SUBCLASSES))
> +		return 0;
> +
>  	if (subclass < NR_LOCKDEP_CACHING_CLASSES)
>  		class = lock->class_cache[subclass];
>  	/*
> -- 
> 2.48.1
>