linux-kernel - Re: [PATCH] arm64: defconfig: Build STMMAC Ethernet driver into the kernel for NFS boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a11ba8a-a9f4-4829-8bcd-56f1702bee8f@linaro.org>
Date: Tue, 6 May 2025 12:52:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Prabhakar <prabhakar.csengg@...il.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] arm64: defconfig: Build STMMAC Ethernet driver into the
 kernel for NFS boot

On 06/05/2025 12:47, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> Enable `CONFIG_STMMAC_ETH` as built-in (`y`) instead of a module (`m`) to
> ensure the Ethernet driver is available early in the boot process. This
> is necessary for platforms mounting the root filesystem via NFS, as the
> driver must be available before the root filesystem is accessed.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Same comments as for previous patches like this (even the same?): you
are supposed to use initramfs for your arm74 boards. Even armv7 boards
use initramfs, so network driver does not have to be built in.

For example all of our setups use it thus we do not have to populate all
other vendors with our own drivers.

Sorry, but I am strongly against such change. Kernel is already way too
big and with KASAN it does not fit to boot partitions in some of the
devices (and I cannot change the boot partition size, at least not
without big effort).


Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof