linux-kernel - Re: [PATCH] kbuild: introduce include/generated/global-rebuild.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250506-innocent-calm-grouse-ebbc2e@l-nschier-aarch64>
Date: Tue, 6 May 2025 12:52:45 +0200
From: Nicolas Schier <nicolas.schier@...ux.dev>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kees Cook <kees@...nel.org>,
	Anton Ivanov <anton.ivanov@...bridgegreys.com>,
	Johannes Berg <johannes@...solutions.net>,
	Nathan Chancellor <nathan@...nel.org>,
	Richard Weinberger <richard@....at>, linux-um@...ts.infradead.org
Subject: Re: [PATCH] kbuild: introduce include/generated/global-rebuild.h

On Sat, May 03, 2025 at 05:41:43PM +0900, Masahiro Yamada wrote:
> Sometimes we need to trigger a global rebuild of the kernel tree -
> for instance, when any of the GCC plugins changes. [1]
> 
> This commit provides a simple mechanism to force a global rebuild
> using a single header file.
> 
> The top-level Makefile creates include/generated/global-rebuild.h if
> it does not exist, and this file is included by all kernel sources.
> 
> You can touch it in a build rule when a global rebuild is required.
> 
> The following is an example change to the GCC plugin build rule.
> 
>   quiet_cmd_plugin_cxx_so_c = HOSTCXX $@
>  -      cmd_plugin_cxx_so_c = $(HOSTCXX) $(plugin_cxxflags) $(plugin_ldflags) -o $@ $<
>  +      cmd_plugin_cxx_so_c = $(HOSTCXX) $(plugin_cxxflags) $(plugin_ldflags) -o $@ $<; touch include/generated/global-rebuild.h
> 
> Link: https://lore.kernel.org/linux-kbuild/CAK7LNATDbxc+3HQ6zoSk9t-Lkf4MSNmEUN6S5EqoVWnBQw_K6g@mail.gmail.com/T/#me069145443a17f0b464c13814424dbba0d970863 [1]
> Cc: Kees Cook <kees@...nel.org>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  Makefile         | 9 ++++++++-
>  arch/um/Makefile | 3 ++-
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 

Looks good to me, thanks!

Reviewed-by: Nicolas Schier <n.schier@....de>
Tested-by: Nicolas Schier <n.schier@....de>