linux-kernel - Re: [PATCH v7 09/11] input: keyboard: Add support for MAX7360 keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D9P32VIGJX5V.1VV0F5MZ17QDW@bootlin.com>
Date: Tue, 06 May 2025 14:41:03 +0200
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@...tlin.com>
To: "Dmitry Torokhov" <dmitry.torokhov@...il.com>, "Andy Shevchenko"
 <andriy.shevchenko@...el.com>
Cc: "Lee Jones" <lee@...nel.org>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Kamel Bouhara" <kamel.bouhara@...tlin.com>, "Linus
 Walleij" <linus.walleij@...aro.org>, "Bartosz Golaszewski" <brgl@...ev.pl>,
 Uwe Kleine-König <ukleinek@...nel.org>, "Michael Walle"
 <mwalle@...nel.org>, "Mark Brown" <broonie@...nel.org>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, "Danilo Krummrich" <dakr@...nel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-gpio@...r.kernel.org>, <linux-input@...r.kernel.org>,
 <linux-pwm@...r.kernel.org>, Grégory Clement
 <gregory.clement@...tlin.com>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v7 09/11] input: keyboard: Add support for MAX7360
 keypad

On Tue May 6, 2025 at 7:14 AM CEST, Dmitry Torokhov wrote:
> On Fri, May 02, 2025 at 01:46:35PM +0300, Andy Shevchenko wrote:
>> On Mon, Apr 28, 2025 at 01:57:27PM +0200, Mathieu Dubois-Briand wrote:
>> > +	error = matrix_keypad_build_keymap(&keymap_data, NULL,
>> > +					   max7360_keypad->rows, max7360_keypad->cols,
>> > +					   max7360_keypad->keycodes, max7360_keypad->input);
>> > +
>> > +	return error;
>> 
>> 	return matrix_...(...);
>
> Because that function has multiple failure points please
>
> 	if (error)
> 		return error; // or return dev_err_probe()
>
> 	return 0;
>
> Thanks.

Noted, I will change this.

Thanks for your review.
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com