linux-kernel - Re: [PATCH v8 5/6] platform/x86: Add Lenovo Gamezone WMI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96885570-f326-49da-b1b2-9048f02a9197@oracle.com>
Date: Tue, 6 May 2025 18:10:33 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Armin Wolf <W_Armin@....de>, Jonathan Corbet <corbet@....net>,
        Mario Limonciello <superm1@...nel.org>, Luke Jones <luke@...nes.dev>,
        Xino Ni <nijs1@...ovo.com>, Zhixin Zhang <zhangzx36@...ovo.com>,
        Mia Shao <shaohz1@...ovo.com>,
        Mark Pearson <mpearson-lenovo@...ebb.ca>,
        "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
        "Cody T . -H . Chiu" <codyit@...il.com>,
        John Martens <johnfanv2@...il.com>,
        platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 5/6] platform/x86: Add Lenovo Gamezone WMI Driver



On 05-05-2025 06:36, Derek J. Clark wrote:
> +static int lwmi_gz_probe(struct wmi_device *wdev, const void *context)
> +{
> +	struct lwmi_gz_priv *priv;
> +	int ret;
> +
> +	priv = devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
> +
> +	priv->wdev = wdev;
> +	dev_set_drvdata(&wdev->dev, priv);
> +
> +	priv->ppdev = devm_platform_profile_register(&wdev->dev, "lenovo-wmi-gamezone",
> +						     priv, &lwmi_gz_platform_profile_ops);
> +
> +	if (IS_ERR(priv->ppdev))
> +		return -ENODEV;
> +
> +	spin_lock_init(&priv->gz_mode_lock);
> +
> +	ret = lwmi_gz_thermal_mode_get(wdev, &priv->current_mode);
> +	if (ret)
> +		return ret;
> +
> +	priv->event_nb.notifier_call = lwmi_gz_event_call;

a '\n' before return

> +	return devm_lwmi_events_register_notifier(&wdev->dev, &priv->event_nb);
> +}
> +
> +static const struct wmi_device_id lwmi_gz_id_table[] = {
> +	{ LENOVO_GAMEZONE_GUID, NULL },
> +	{}
> +};

Reviewed-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Thanks,
Alok