linux-kernel - Re: [PATCH AUTOSEL 6.14 342/642] fs/mpage: avoid negative shift for large blocksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBoT89awjNjboEe8@lappy>
Date: Tue, 6 May 2025 09:51:47 -0400
From: Sasha Levin <sashal@...nel.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Hannes Reinecke <hare@...nel.org>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Hannes Reinecke <hare@...e.de>,
	Christian Brauner <brauner@...nel.org>, viro@...iv.linux.org.uk,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.14 342/642] fs/mpage: avoid negative shift for
 large blocksize

On Mon, May 05, 2025 at 06:01:55PM -0700, Luis Chamberlain wrote:
>On Mon, May 05, 2025 at 06:09:18PM -0400, Sasha Levin wrote:
>> From: Hannes Reinecke <hare@...nel.org>
>>
>> [ Upstream commit 86c60efd7c0ede43bd677f2eee1d84200528df1e ]
>>
>> For large blocksizes the number of block bits is larger than PAGE_SHIFT,
>> so calculate the sector number from the byte offset instead. This is
>> required to enable large folios with buffer-heads.
>>
>> Reviewed-by: "Matthew Wilcox (Oracle)" <willy@...radead.org>
>> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
>> Signed-off-by: Hannes Reinecke <hare@...nel.org>
>> Link: https://lore.kernel.org/r/20250221223823.1680616-4-mcgrof@kernel.org
>> Reviewed-by: Hannes Reinecke <hare@...e.de>
>> Signed-off-by: Christian Brauner <brauner@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>This is not relevant to older kernels as we had no buffer-head usage of
>large folios before v6.15. So this is just creating noise / drama for
>older kernels.

Sure, I'll drop it.

>Where's that code for  auto-sel again?

https://git.sr.ht/~sashal/autosel :)

-- 
Thanks,
Sasha