linux-kernel - Re: [PATCH v8 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D9P4WPCRV2MD.VZE4Q37U0O63@gmail.com>
Date: Tue, 06 May 2025 11:07:02 -0300
From: "Kurt Borja" <kuurtb@...il.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>, "Hans de Goede"
 <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>
Cc: "Armin Wolf" <W_Armin@....de>, "Jonathan Corbet" <corbet@....net>,
 "Mario Limonciello" <superm1@...nel.org>, "Luke Jones" <luke@...nes.dev>,
 "Xino Ni" <nijs1@...ovo.com>, "Zhixin Zhang" <zhangzx36@...ovo.com>, "Mia
 Shao" <shaohz1@...ovo.com>, "Mark Pearson" <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>, "Cody T . -H .
 Chiu" <codyit@...il.com>, "John Martens" <johnfanv2@...il.com>,
 <platform-driver-x86@...r.kernel.org>, <linux-doc@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Alok Tiwari" <alok.a.tiwari@...cle.com>
Subject: Re: [PATCH v8 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

On Sun May 4, 2025 at 10:06 PM -03, Derek J. Clark wrote:
> Adds lenovo-wmi-other driver which provides the Lenovo "Other Mode" WMI
> interface that comes on some Lenovo "Gaming Series" hardware. Provides a
> firmware-attributes class which enables the use of tunable knobs for SPL,
> SPPT, and FPPT.
>
> Reviewed-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> Reviewed-by: Armin Wolf <W_Armin@....de>
> Signed-off-by: Derek J. Clark <derekjohn.clark@...il.com>
> ---
...
> +struct tunable_attr_01 ppt_pl1_spl = { .device_id = LWMI_DEVICE_ID_CPU,
> +				       .feature_id = LWMI_FEATURE_ID_CPU_SPL,
> +				       .type_id = LWMI_TYPE_ID_NONE };
> +struct tunable_attr_01 ppt_pl2_sppt = { .device_id = LWMI_DEVICE_ID_CPU,
> +					.feature_id = LWMI_FEATURE_ID_CPU_SPPT,
> +					.type_id = LWMI_TYPE_ID_NONE };
> +struct tunable_attr_01 ppt_pl3_fppt = { .device_id = LWMI_DEVICE_ID_CPU,
> +					.feature_id = LWMI_FEATURE_ID_CPU_FPPT,
> +					.type_id = LWMI_TYPE_ID_NONE };

Sparse warns about these symbols not being static.

-- 
 ~ Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)