linux-kernel - Re: [PATCH v8 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505090501.4WrdCVBb-lkp@intel.com>
Date: Fri, 9 May 2025 05:53:32 +0800
From: kernel test robot <lkp@...el.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, Armin Wolf <W_Armin@....de>,
	Jonathan Corbet <corbet@....net>,
	Mario Limonciello <superm1@...nel.org>,
	Luke Jones <luke@...nes.dev>, Xino Ni <nijs1@...ovo.com>,
	Zhixin Zhang <zhangzx36@...ovo.com>, Mia Shao <shaohz1@...ovo.com>,
	Mark Pearson <mpearson-lenovo@...ebb.ca>,
	"Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
	"Cody T . -H . Chiu" <codyit@...il.com>,
	John Martens <johnfanv2@...il.com>,
	"Derek J . Clark" <derekjohn.clark@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alok Tiwari <alok.a.tiwari@...cle.com>
Subject: Re: [PATCH v8 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

Hi Derek,

kernel test robot noticed the following build warnings:

[auto build test WARNING on amd-pstate/linux-next]
[also build test WARNING on amd-pstate/bleeding-edge linus/master v6.15-rc5 next-20250508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Derek-J-Clark/platform-x86-Add-lenovo-wmi-driver-Documentation/20250505-123422
base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link:    https://lore.kernel.org/r/20250505010659.1450984-7-derekjohn.clark%40gmail.com
patch subject: [PATCH v8 6/6] platform/x86: Add Lenovo Other Mode WMI Driver
config: i386-randconfig-r133-20250508 (https://download.01.org/0day-ci/archive/20250509/202505090501.4WrdCVBb-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505090501.4WrdCVBb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505090501.4WrdCVBb-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/platform/x86/lenovo-wmi-gamezone.c:128:38: sparse: sparse: Using plain integer as NULL pointer
   drivers/platform/x86/lenovo-wmi-gamezone.c:142:38: sparse: sparse: Using plain integer as NULL pointer
   drivers/platform/x86/lenovo-wmi-gamezone.c:155:12: sparse: sparse: context imbalance in 'lwmi_gz_profile_get' - different lock contexts for basic block
   drivers/platform/x86/lenovo-wmi-gamezone.c:206:12: sparse: sparse: context imbalance in 'lwmi_gz_profile_set' - different lock contexts for basic block

vim +128 drivers/platform/x86/lenovo-wmi-gamezone.c

fc3651e7b6ebda Derek J. Clark 2025-05-04  115  
fc3651e7b6ebda Derek J. Clark 2025-05-04  116  /**
fc3651e7b6ebda Derek J. Clark 2025-05-04  117   * lwmi_gz_thermal_mode_supported() - Get the version of the WMI
fc3651e7b6ebda Derek J. Clark 2025-05-04  118   * interface to determine the support level.
fc3651e7b6ebda Derek J. Clark 2025-05-04  119   * @wdev: The Gamezone WMI device.
fc3651e7b6ebda Derek J. Clark 2025-05-04  120   * @supported: Pointer to return the support level with.
fc3651e7b6ebda Derek J. Clark 2025-05-04  121   *
fc3651e7b6ebda Derek J. Clark 2025-05-04  122   * Return: 0 on success, or an error code.
fc3651e7b6ebda Derek J. Clark 2025-05-04  123   */
fc3651e7b6ebda Derek J. Clark 2025-05-04  124  static int lwmi_gz_thermal_mode_supported(struct wmi_device *wdev,
fc3651e7b6ebda Derek J. Clark 2025-05-04  125  					  int *supported)
fc3651e7b6ebda Derek J. Clark 2025-05-04  126  {
fc3651e7b6ebda Derek J. Clark 2025-05-04  127  	return lwmi_dev_evaluate_int(wdev, 0x0, LWMI_GZ_METHOD_ID_SMARTFAN_SUP,
fc3651e7b6ebda Derek J. Clark 2025-05-04 @128  				     0, 0, supported);
fc3651e7b6ebda Derek J. Clark 2025-05-04  129  }
fc3651e7b6ebda Derek J. Clark 2025-05-04  130  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki