linux-kernel - Re: [PATCH 6/7] rtc: s3c: drop unused module alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBoeFUbBKsNoqyd7@hovoldconsulting.com>
Date: Tue, 6 May 2025 16:35:01 +0200
From: Johan Hovold <johan@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Johan Hovold <johan+linaro@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Paul Cercueil <paul@...pouillou.net>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Sebastian Reichel <sre@...nel.org>, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] rtc: s3c: drop unused module alias

On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote:
> On 23/04/2025 15:03, Johan Hovold wrote:
> > The driver only support OF probe so drop the unused platform module
> > alias.
> > 
> > Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
> 
> I believe this is not correct, but instead commit dropping last platform
> user, which I think was:
> 
> Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")

No, as I write in the commit message, the driver only supports OF probe
since the commit I refer to. It fails with -EINVAL and the following
error logged:

	failed getting s3c_rtc_data

for non-OF probe.

> Just like in other patches here, these are old drivers and even if they
> have OF matching method, they can be or they were modprobed via board files.

See above, similar reasoning applies for the other patches.

Johan