linux-kernel - Re: [PATCH 6/7] rtc: s3c: drop unused module alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c41c15f-c1de-4329-b671-78268f99431b@kernel.org>
Date: Tue, 6 May 2025 16:45:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: Johan Hovold <johan+linaro@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Paul Cercueil <paul@...pouillou.net>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Sebastian Reichel <sre@...nel.org>, linux-rtc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] rtc: s3c: drop unused module alias

On 06/05/2025 16:35, Johan Hovold wrote:
> On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote:
>> On 23/04/2025 15:03, Johan Hovold wrote:
>>> The driver only support OF probe so drop the unused platform module
>>> alias.
>>>
>>> Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
>>
>> I believe this is not correct, but instead commit dropping last platform
>> user, which I think was:
>>
>> Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")
> 
> No, as I write in the commit message, the driver only supports OF probe
> since the commit I refer to. It fails with -EINVAL and the following
> error logged:
> 
> 	failed getting s3c_rtc_data
> 
> for non-OF probe.

Haha, nice, so commit in 2014 nicely broke that platform's RTC.

There is one more thing: back in 2013-2015, I don't remember exactly,
the module loading/matching was not working with OF and you needed
aliases for the actual bus - platform or I2C. IIRC, the bus - platform
bus in this case - trigger uevent for module and then device match would
be via OF.

Anyway, this would be only for s3c2410 DT platform, because all others
(newer) use different compatible thus there would be no s3c2410-rtc
uevent for them.

Well, does not matter much, just sharing.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof