linux-kernel - Re: [PATCH RESEND 1/3] spi: tegra210-quad: Add iommus property to DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0aedf5fb-557b-4c8c-a336-182498e2c3ea@kernel.org>
Date: Tue, 6 May 2025 17:54:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vishwaroop A <va@...dia.com>, broonie@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, thierry.reding@...il.com,
 jonathanh@...dia.com, skomatineni@...dia.com, ldewangan@...dia.com,
 kyarlagadda@...dia.com, smangipudi@...dia.com, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/3] spi: tegra210-quad: Add iommus property to DT
 bindings

On 06/05/2025 17:23, Vishwaroop A wrote:
> The Tegra210 Quad SPI controller uses internal DMA engines to
> efficiently transfer data between system memory and the SPI bus.
> On platforms with an IOMMU, such as Tegra234, DMA transactions
> must be properly mapped and protected to ensure system security
> and functional correctness.

Does this mean this is not valid for other platforms? Then in
allOf:if:then: disallow it (iommus: false) for hardware this is invalid.

> 
> This patch adds the iommus property to the device tree binding.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> This property is required to associate the SPI controller with
> the system IOMMU, specifying the correct stream ID for address
> translation and access protection.
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Missing: dt-bindings

Best regards,
Krzysztof