linux-kernel - Re: [PATCH v2 2/2] dm: pass through operations on wrapped inline crypto keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a0ef010-ec08-de32-134f-80286a3960c9@redhat.com>
Date: Tue, 6 May 2025 19:14:06 +0200 (CEST)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Eric Biggers <ebiggers@...nel.org>
cc: dm-devel@...ts.linux.dev, Alasdair Kergon <agk@...hat.com>, 
    Mike Snitzer <snitzer@...nel.org>, linux-block@...r.kernel.org, 
    linux-kernel@...r.kernel.org, linux-fscrypt@...r.kernel.org, 
    Bartosz Golaszewski <brgl@...ev.pl>, 
    Gaurav Kashyap <quic_gaurkash@...cinc.com>
Subject: Re: [PATCH v2 2/2] dm: pass through operations on wrapped inline
 crypto keys



On Mon, 5 May 2025, Eric Biggers wrote:

> We have to forward derive_sw_secret anyway, since that's invoked by the
> filesystem, not by the ioctls.
> 
> The other operations are for the ioctls, but I don't see a reason to make things
> harder for userspace by forcing userspace to implement logic like:
> 
>     if (is_dm(blkdev))
>         blkdev = underlying_device(blkdev)
>     ioctl(blkdev)
> 
> The device-mapper block device has a blk-crypto profile that declares wrapped
> key support.  We should just make the ioctls work on that block device, so that
> upper layers don't need to care whether it's device-mapper or native.
> 
> - Eric

OK, I accepted both patches for the next merge window.

Mikulas