linux-kernel - Re: [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU property for Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea922410-d3e5-4406-9c16-3ac920caab89@kernel.org>
Date: Tue, 6 May 2025 20:12:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vishwaroop A <va@...dia.com>, broonie@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, thierry.reding@...il.com,
 jonathanh@...dia.com, skomatineni@...dia.com, ldewangan@...dia.com,
 kyarlagadda@...dia.com, smangipudi@...dia.com, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU
 property for Tegra234

On 06/05/2025 19:58, Vishwaroop A wrote:
> The Tegra210 Quad SPI controller uses internal DMA engines to efficiently transfer data between system memory and the SPI bus. On Tegra234 platform, DMA transactions must be properly mapped and protected through IOMMU to ensure system security and functional correctness. Tegra241 uses external DMA and doesn't require IOMMU.


Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

I don't think you read the review, just skimmed. I explained there how
to construct subject prefix and gave a link explaining it better.

Can you reach to your colleagues to help in upstreaming process to avoid
easy mistakes? Many companies have internal checklists or internal
guides helping in that...

> 
> Add the iommus property to the device tree binding, making it required only for Tegra234 platform while explicitly disallowing it for other platforms including Tegra241.

Why requiring it for Tegra234? Do not explain what you did - we see it
easily. Explain what we do not see, so why you are breaking ABI.


Best regards,
Krzysztof