[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a4c935a7-0723-46c9-8f85-09f5c895833d@kernel.org>
Date: Tue, 6 May 2025 20:14:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vishwaroop A <va@...dia.com>, broonie@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, thierry.reding@...il.com,
jonathanh@...dia.com, skomatineni@...dia.com, ldewangan@...dia.com,
kyarlagadda@...dia.com, smangipudi@...dia.com, linux-spi@...r.kernel.org,
devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU
property for Tegra234
On 06/05/2025 20:08, Vishwaroop A wrote:
> The Tegra210 Quad SPI controller uses internal DMA engines to efficiently
> transfer data between system memory and the SPI bus. On Tegra234 platform,
> DMA transactions must be properly mapped and protected through IOMMU to
> ensure system security and functional correctness. Tegra241 uses external
> DMA and doesn't require IOMMU.
>
> Add the iommus property to the device tree binding, making it required
> only for Tegra234 platform while explicitly disallowing it for other
> platforms including Tegra241.
>
> Signed-off-by: Vishwaroop A <va@...dia.com>
That's another v2? I reviewed one. Some of my comments are still valid.
Can you slow down with new versions and spend some time to read the
feedback you receive?
Best regards,
Krzysztof
Powered by blists - more mailing lists