linux-kernel - Re: [PATCH net v2 3/3] net: ti: icssg-prueth: Report BQL before sending XDP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbd00914-b17c-4f96-b204-21c9bf95158b@intel.com>
Date: Tue, 6 May 2025 11:22:35 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Meghana Malladi <m-malladi@...com>, <namcao@...utronix.de>,
	<horms@...nel.org>, <john.fastabend@...il.com>, <hawk@...nel.org>,
	<daniel@...earbox.net>, <ast@...nel.org>, <pabeni@...hat.com>,
	<kuba@...nel.org>, <edumazet@...gle.com>, <davem@...emloft.net>,
	<andrew+netdev@...n.ch>
CC: <bpf@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<srk@...com>, Vignesh Raghavendra <vigneshr@...com>, Roger Quadros
	<rogerq@...nel.org>, <danishanwar@...com>
Subject: Re: [PATCH net v2 3/3] net: ti: icssg-prueth: Report BQL before
 sending XDP packets



On 5/6/2025 4:05 AM, Meghana Malladi wrote:
> When sending out any kind of traffic, it is essential that the driver
> keeps reporting BQL of the number of bytes that have been sent so that
> BQL can track the amount of data in the queue and prevents it from
> overflowing. If BQL is not reported, the driver may continue sending
> packets even when the queue is full, leading to packet loss, congestion
> and decreased network performance. Currently this is missing in
> emac_xmit_xdp_frame() and this patch fixes it.
> 
> Fixes: 62aa3246f462 ("net: ti: icssg-prueth: Add XDP support")
> Signed-off-by: Meghana Malladi <m-malladi@...com>
> ---
> 
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>