linux-kernel - Re: [PATCH 0/4] PM: TI: AM335x: PM STANDBY fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e014361-65ec-4b6e-839d-bfeb995262c6@ti.com>
Date: Tue, 6 May 2025 15:01:41 -0500
From: Judith Mendez <jm@...com>
To: Sukrut Bellary <sbellary@...libre.com>,
        Kevin Hilman
	<khilman@...libre.com>, Nishanth Menon <nm@...com>,
        Ulf Hansson
	<ulf.hansson@...aro.org>
CC: Aaro Koskinen <aaro.koskinen@....fi>,
        Andreas Kemnade
	<andreas@...nade.info>,
        Roger Quadros <rogerq@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Bajjuri
 Praneeth <praneeth@...com>,
        Raghavendra Vignesh <vigneshr@...com>, Bin Liu
	<b-liu@...com>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, Russell King
	<linux@...linux.org.uk>,
        Rob Herring <robh@...nel.org>, Tony Lindgren
	<tony@...mide.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH 0/4] PM: TI: AM335x: PM STANDBY fixes

Hello Sukrut, Keven, Ulf,

On 3/18/25 6:00 PM, Sukrut Bellary wrote:
> This patch series fixes the Power management issues on TI's am335x soc.
> 
> on AM335x, the wakeup doesn't work in the case of STANDBY.
> 
> 1. Since CM3 PM FW [1](ti-v4.1.y) doesn't enable l4ls clockdomain upon
> wakeup, it fails to wakeup the MPU.
> To fix this, don't turn off the l4ls clk domain in the STANDBY transition
> in MPU.
> 
> 2. Also Per AM335x TRM [2](section 8.1.4.3 Power mode), in case of STANDBY,
> PER domain should be ON. So fix PER power domain handling for
> standby. l4ls is a part of the PER domain.
> 
> Since we are not turning off the l4ls clockdomain on STANDBY in MPU,
> PER power domain would remain ON. But still, explicitly handle this
> to be in sync with the STANDBY requirement.
> 
> 3. On am335x evm[1], UART0 - (UART1-HW) has a wakeup capability.
> Set the wakeup-source property in DT for AM335x.
> 
> 4. Enable PM configs for AM335x.
> 
> [1] https://git.ti.com/cgit/processor-firmware/ti-amx3-cm3-pm-firmware/
> [2] https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf
> [3] https://www.ti.com/tool/TMDXEVM3358
> 
> Test log:
> https://gist.github.com/sukrutb/bdbfd1220fe8578a9decf87d0bac6796
> 

Thanks for the patches, Sukrut.

I was able to test this series on am335x EVM, baseline being rc5 next
branch: https://gist.github.com/jmenti/cda1675b5fc5844b6f065376e98026f5

Tested-by: Judith Mendez <jm@...com>

regards,
~ Judith