linux-kernel - Re: [PATCH 2/4] pmdomain: ti: Fix STANDBY handling of PER power domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hjz6rtfc0.fsf@baylibre.com>
Date: Thu, 08 May 2025 06:14:07 -0700
From: Kevin Hilman <khilman@...libre.com>
To: Sukrut Bellary <sbellary@...libre.com>, Russell King
 <linux@...linux.org.uk>, Rob Herring <robh@...nel.org>, Tony Lindgren
 <tony@...mide.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Nishanth
 Menon <nm@...com>, Ulf Hansson <ulf.hansson@...aro.org>
Cc: Sukrut Bellary <sbellary@...libre.com>, Aaro Koskinen
 <aaro.koskinen@....fi>, Andreas Kemnade <andreas@...nade.info>, Roger
 Quadros <rogerq@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Santosh
 Shilimkar <ssantosh@...nel.org>, Bajjuri Praneeth <praneeth@...com>,
 Raghavendra Vignesh <vigneshr@...com>, Bin Liu <b-liu@...com>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/4] pmdomain: ti: Fix STANDBY handling of PER power domain

Sukrut Bellary <sbellary@...libre.com> writes:

> Per AM335x TRM[1](section 8.1.4.3 Power mode), in case of STANDBY,
> PER domain should be ON. So, fix the PER power domain handling on standby.
>
> [1] https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf
>
> Signed-off-by: Sukrut Bellary <sbellary@...libre.com>

Reviewed-by: Kevin Hilman <khilman@...libre.com>

Ulf, this series has been tested now.  Go ahead and take this patch.

Thanks,

Kevin


> ---
>  drivers/pmdomain/ti/omap_prm.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c
> index b8ceb3c2b81c..7e36e675a8c6 100644
> --- a/drivers/pmdomain/ti/omap_prm.c
> +++ b/drivers/pmdomain/ti/omap_prm.c
> @@ -18,7 +18,9 @@
>  #include <linux/pm_domain.h>
>  #include <linux/reset-controller.h>
>  #include <linux/delay.h>
> -
> +#if IS_ENABLED(CONFIG_SUSPEND)
> +#include <linux/suspend.h>
> +#endif
>  #include <linux/platform_data/ti-prm.h>
>  
>  enum omap_prm_domain_mode {
> @@ -88,6 +90,7 @@ struct omap_reset_data {
>  #define OMAP_PRM_HAS_RSTST	BIT(1)
>  #define OMAP_PRM_HAS_NO_CLKDM	BIT(2)
>  #define OMAP_PRM_RET_WHEN_IDLE	BIT(3)
> +#define OMAP_PRM_ON_WHEN_STANDBY	BIT(4)
>  
>  #define OMAP_PRM_HAS_RESETS	(OMAP_PRM_HAS_RSTCTRL | OMAP_PRM_HAS_RSTST)
>  
> @@ -404,7 +407,8 @@ static const struct omap_prm_data am3_prm_data[] = {
>  		.name = "per", .base = 0x44e00c00,
>  		.pwrstctrl = 0xc, .pwrstst = 0x8, .dmap = &omap_prm_noinact,
>  		.rstctrl = 0x0, .rstmap = am3_per_rst_map,
> -		.flags = OMAP_PRM_HAS_RSTCTRL, .clkdm_name = "pruss_ocp"
> +		.flags = OMAP_PRM_HAS_RSTCTRL | OMAP_PRM_ON_WHEN_STANDBY,
> +		.clkdm_name = "pruss_ocp",
>  	},
>  	{
>  		.name = "wkup", .base = 0x44e00d00,
> -- 
> 2.34.1