linux-kernel - Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO forwarder library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb98bec7-748c-4e00-aa9f-b5075bebb5b2@bootlin.com>
Date: Wed, 7 May 2025 16:53:00 +0200
From: Thomas Richard <thomas.richard@...tlin.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Bartosz Golaszewski <brgl@...ev.pl>,
 Geert Uytterhoeven <geert+renesas@...der.be>, Kees Cook <kees@...nel.org>,
 Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
 DanieleCleri@...on.eu, GaryWang@...on.com.tw, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO
 forwarder library

On 5/7/25 08:29, Andy Shevchenko wrote:
>> +/**
>> + * gpio_fwd_gpio_add - Add a GPIO in the forwarder
> 
> forwarder

Sorry I do not see the typo :)

> 
>> + * @fwd: GPIO forwarder
>> + * @desc: GPIO decriptor to register
> 
> descriptor
> 
>> + * @offset: offset for the GPIO in the forwarder
>> + *
>> + * Returns: 0 on success, or negative errno on failure.
>> + */
> 
> Please, spellcheck all of the comments.

Ditto

> 
> ...
> 
>> +#ifndef __LINUX_GPIO_FORWARDER_H
>> +#define __LINUX_GPIO_FORWARDER_H
> 
>> +#include <linux/gpio/consumer.h>
>> +#include <linux/gpio/driver.h>
> 
> These are not used (at least as of this patch).

Indeed they are only needed in the pinctrl driver.

> 
> + struct gpio_chip;

And also struct gpio_desc;

Regards,

Thomas