linux-kernel - Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO forwarder library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve_oM6NyvLGsBK4CddEEv=cafw_VfONKwEBX2CBdNxJmA@mail.gmail.com>
Date: Wed, 7 May 2025 18:21:58 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Kees Cook <kees@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	thomas.petazzoni@...tlin.com, DanieleCleri@...on.eu, GaryWang@...on.com.tw, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO
 forwarder library

On Wed, May 7, 2025 at 5:53 PM Thomas Richard
<thomas.richard@...tlin.com> wrote:
> On 5/7/25 08:29, Andy Shevchenko wrote:
> >> +/**
> >> + * gpio_fwd_gpio_add - Add a GPIO in the forwarder
> >
> > forwarder
>
> Sorry I do not see the typo :)

Your original piece of the code. Please look better.

-static int gpiochip_fwd_gpio_add(struct gpiochip_fwd *fwd,
-                                struct gpio_desc *desc,
-                                unsigned int offset)
+/**
+ * gpio_fwd_gpio_add - Add a GPIO in the forwader


> >> + * @fwd: GPIO forwarder
> >> + * @desc: GPIO decriptor to register
> >
> > descriptor

Ditto.

> >> + * @offset: offset for the GPIO in the forwarder
> >> + *
> >> + * Returns: 0 on success, or negative errno on failure.
> >> + */
> >
> > Please, spellcheck all of the comments.
>
> Ditto

See above and spell check. Thank you.

...

> > + struct gpio_chip;
>
> And also struct gpio_desc;

Yes. :-)

-- 
With Best Regards,
Andy Shevchenko