linux-kernel - Re: [PATCH] ARM: dts: bananapi: add support for PHY LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v671wD7y6n6n20BrhH-pcTGD8RzPp25gCWUtnFmRhh=naw@mail.gmail.com>
Date: Thu, 8 May 2025 00:45:28 +0900
From: Chen-Yu Tsai <wens@...e.org>
To: Michael Klein <michael@...sekall.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Samuel Holland <samuel@...lland.org>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: bananapi: add support for PHY LEDs

On Wed, May 7, 2025 at 4:56 AM Michael Klein <michael@...sekall.de> wrote:
>
> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
> Add the corresponding nodes to the device tree.

I see from old emails that this was supposed to be updated? And if you
didn't, then his patch should be marked as a "RESEND", so tooling doesn't
get confused and ignore it.

I'll wait a couple days in case anyone else wants to take a look.

ChenYu

> Signed-off-by: Michael Klein <michael@...sekall.de>
> ---
>  .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> index 46ecf9db2324..d8b362c9661a 100644
> --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> @@ -48,6 +48,7 @@
>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
>
>  / {
>         model = "LeMaker Banana Pi";
> @@ -169,6 +170,32 @@ &ir0 {
>  &gmac_mdio {
>         phy1: ethernet-phy@1 {
>                 reg = <1>;
> +
> +               leds {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       led@0 {
> +                               reg = <0>;
> +                               color = <LED_COLOR_ID_GREEN>;
> +                               function = LED_FUNCTION_LAN;
> +                               linux,default-trigger = "netdev";
> +                       };
> +
> +                       led@1 {
> +                               reg = <1>;
> +                               color = <LED_COLOR_ID_AMBER>;
> +                               function = LED_FUNCTION_LAN;
> +                               linux,default-trigger = "netdev";
> +                       };
> +
> +                       led@2 {
> +                               reg = <2>;
> +                               color = <LED_COLOR_ID_BLUE>;
> +                               function = LED_FUNCTION_LAN;
> +                               linux,default-trigger = "netdev";
> +                       };
> +               };
>         };
>  };
>
> --
> 2.39.5
>
>