linux-kernel - Re: [PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKve4hXiR31ApMADEz3NqD_futjETWrPKEWz3tADsX7gA@mail.gmail.com>
Date: Wed, 7 May 2025 11:33:09 -0500
From: Rob Herring <robh@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: Convert arm,sbsa-uart to DT schema

On Wed, May 7, 2025 at 10:54 AM Andre Przywara <andre.przywara@....com> wrote:
>
> On Tue,  6 May 2025 17:00:15 -0500
> "Rob Herring (Arm)" <robh@...nel.org> wrote:
>
> > Convert the Arm SBSA UART binding to DT schema. It is a straight-forward
> > conversion.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> >
> > ---
> >  .../bindings/serial/arm,sbsa-uart.yaml        | 38 +++++++++++++++++++
> >  .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
> >  2 files changed, 38 insertions(+), 10 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
> >
> > diff --git a/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> > new file mode 100644
> > index 000000000000..68e3fd64b1d8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +---
> > +$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ARM SBSA UART
> > +
> > +maintainers:
> > +  - Andre Przywara <andre.przywara@....com>
> > +
> > +description:
> > +  This UART uses a subset of the PL011 registers and consequently lives in the
> > +  PL011 driver. It's baudrate and other communication parameters cannot be
>
> He said "driver" in a binding document!! ;-) I think you can remove that
> part, or maybe rephrase it to say it could be supported by the same driver
> that supports a PL011.

I know that's 'the rule', but I kind of think that's relevant in this
case. If we're looking for improvements, defining SBSA here might be
the place to start... But I'm not really as this is 1 of 1100
remaining I've had chatgpt to convert and then I fix all the issues.

Rob