linux-kernel - Re: [PATCH v9 14/27] x86/resctrl: Fix types in resctrl_arch_mon_ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28fb6da2-2d89-49c8-a8e7-d5527d8da000@arm.com>
Date: Wed, 7 May 2025 17:48:22 +0100
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>, fenghuay@...dia.com
Subject: Re: [PATCH v9 14/27] x86/resctrl: Fix types in
 resctrl_arch_mon_ctx_alloc() and free stubs

Hi Reinette,

On 01/05/2025 18:27, Reinette Chatre wrote:
> The shortlog sounds like the stubs themselves are being free'd. How about
>     x86/resctrl: Fix types in resctrl_arch_mon_ctx_{alloc,free}() stubs

Sure,


> On 4/25/25 10:37 AM, James Morse wrote:
>> resctrl_arch_mon_ctx_alloc() and resctrl_arch_mon_ctx_free() take an enum
>> resctrl_event_id. This in turn requires the enum to be defined in
>> resctrl_types.h so that it is accessible to asm/resctrl.h.
> 
> I found the "This in turn requires ..." to indicate that this dependency
> still needs to be met. How about:
> 
>  resctrl_arch_mon_ctx_alloc() and resctrl_arch_mon_ctx_free() take an enum
>  resctrl_event_id that is already defined in resctrl_types.h to be accessible
>  to asm/resctrl.h.

Done,


>> The x86 stubs take an int. Fix that.
>>
>> Signed-off-by: James Morse <james.morse@....com>
>> ---
> 
> 
> 
>> diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
>> index 7a39728b0743..bd149c37551c 100644
>> --- a/arch/x86/include/asm/resctrl.h
>> +++ b/arch/x86/include/asm/resctrl.h
>> @@ -194,13 +194,15 @@ static inline u32 resctrl_arch_rmid_idx_encode(u32 ignored, u32 rmid)
>>  
>>  /* x86 can always read an rmid, nothing needs allocating */
>>  struct rdt_resource;
>> -static inline void *resctrl_arch_mon_ctx_alloc(struct rdt_resource *r, int evtid)
>> +static inline void *resctrl_arch_mon_ctx_alloc(struct rdt_resource *r,
>> +					       enum resctrl_event_id evtid)
>>  {
>>  	might_sleep();
>>  	return NULL;
>>  };
> 
> I missed this stray ";" sneaking in ...
> 
>>  
>> -static inline void resctrl_arch_mon_ctx_free(struct rdt_resource *r, int evtid,
>> +static inline void resctrl_arch_mon_ctx_free(struct rdt_resource *r,
>> +					     enum resctrl_event_id evtid,
>>  					     void *ctx) { };
>>  
> ... and this one.


Both removed - not sure how that happened!


Thanks,

James