linux-kernel - Re: [PATCH v9 13/27] x86/resctrl: Move enum resctrl_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5e01a7-db25-4175-b1ae-0635660e44e7@arm.com>
Date: Wed, 7 May 2025 17:48:15 +0100
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>, fenghuay@...dia.com
Subject: Re: [PATCH v9 13/27] x86/resctrl: Move enum resctrl_event_id to
 resctrl.h

Hi Reinette,

On 01/05/2025 18:19, Reinette Chatre wrote:
> On 4/25/25 10:37 AM, James Morse wrote:
>> A previous patch moved enum resctrl_event_id into a smaller header file,
> 
> We have had trouble using "previous patch" and "next patch" in changelogs
> because of how patches may be re-organized after merge and backports and such.

I glossed over this because it was the distant past!

> Considering this I'd propose something like (please feel free to improve):
> 
>   resctrl_types.h contains common types and constants to enable architectures
>   to use these types in their definitions within asm/resctrl.h.
>   
>   enum resctrl_event_id was placed in resctrl_types.h for
>   resctrl_arch_get_cdp_enabled() and resctrl_arch_set_cdp_enabled(), but
>   these two functions are no longer inlined by any architecture.
> 
>   Move enum resctrl_event_id to resctrl.h.

I've taken this as it is.


> With "previous patch" addressed:
> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>


Thanks!

James