linux-kernel - Re: [PATCH v2 2/2] binder: Create safe versions of binder log files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBuejWpfghiB9f7-@google.com>
Date: Wed, 7 May 2025 17:55:25 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: kernel test robot <lkp@...el.com>
Cc: Tiffany Yang <ynaffit@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	kernel-team@...roid.com
Subject: Re: [PATCH v2 2/2] binder: Create safe versions of binder log files

On Wed, May 07, 2025 at 08:19:07PM +0800, kernel test robot wrote:
> Hi Tiffany,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on staging/staging-testing]
> [also build test WARNING on staging/staging-next staging/staging-linus linus/master v6.15-rc5 next-20250506]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Tiffany-Yang/binder-Create-safe-versions-of-binder-log-files/20250506-054556
> base:   staging/staging-testing
> patch link:    https://lore.kernel.org/r/20250505214306.3843294-4-ynaffit%40google.com
> patch subject: [PATCH v2 2/2] binder: Create safe versions of binder log files
> config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20250507/202505072254.2gHv8kgu-lkp@intel.com/config)
> compiler: or1k-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505072254.2gHv8kgu-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505072254.2gHv8kgu-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/android/binder.c: In function 'print_binder_work_ilocked':
> >> drivers/android/binder.c:6409:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     6409 |                            (void *)node->ptr, (void *)node->cookie);
>          |                            ^
>    drivers/android/binder.c:6409:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     6409 |                            (void *)node->ptr, (void *)node->cookie);
>          |                                               ^
>    drivers/android/binder.c: In function 'print_binder_node_nilocked':
>    drivers/android/binder.c:6487:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     6487 |                            (void *)node->ptr, (void *)node->cookie);
>          |                            ^
>    drivers/android/binder.c:6487:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     6487 |                            (void *)node->ptr, (void *)node->cookie);
>          |                                               ^

Oh right, this is silly. The reason is us _not_ using fixed-sized in our
uapi, which was unfortunate. In Android we don't have 32bit builds that
typedef 'binder_uinptr_t' to __u64 as we always pass -DBINDER_IPC_32BIT
for such cases. It is not the case outside of Android though, so this
needs a double explicit cast. :(

	#ifdef BINDER_IPC_32BIT
	typedef __u32 binder_size_t;
	typedef __u32 binder_uintptr_t;
	#else
	typedef __u64 binder_size_t;
	typedef __u64 binder_uintptr_t;
	#endif