linux-kernel - Re: [PATCH v2 2/2] binder: Create safe versions of binder log files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202505072254.2gHv8kgu-lkp@intel.com>
Date: Wed, 7 May 2025 20:19:07 +0800
From: kernel test robot <lkp@...el.com>
To: Tiffany Yang <ynaffit@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Christian Brauner <brauner@...nel.org>,
	Carlos Llamas <cmllamas@...gle.com>,
	Suren Baghdasaryan <surenb@...gle.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	kernel-team@...roid.com, "Tiffany Y. Yang" <ynaffit@...gle.com>
Subject: Re: [PATCH v2 2/2] binder: Create safe versions of binder log files

Hi Tiffany,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on staging/staging-next staging/staging-linus linus/master v6.15-rc5 next-20250506]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tiffany-Yang/binder-Create-safe-versions-of-binder-log-files/20250506-054556
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250505214306.3843294-4-ynaffit%40google.com
patch subject: [PATCH v2 2/2] binder: Create safe versions of binder log files
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20250507/202505072254.2gHv8kgu-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505072254.2gHv8kgu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505072254.2gHv8kgu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/android/binder.c: In function 'print_binder_work_ilocked':
>> drivers/android/binder.c:6409:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    6409 |                            (void *)node->ptr, (void *)node->cookie);
         |                            ^
   drivers/android/binder.c:6409:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    6409 |                            (void *)node->ptr, (void *)node->cookie);
         |                                               ^
   drivers/android/binder.c: In function 'print_binder_node_nilocked':
   drivers/android/binder.c:6487:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    6487 |                            (void *)node->ptr, (void *)node->cookie);
         |                            ^
   drivers/android/binder.c:6487:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    6487 |                            (void *)node->ptr, (void *)node->cookie);
         |                                               ^


vim +6409 drivers/android/binder.c

  6378	
  6379	static void print_binder_work_ilocked(struct seq_file *m,
  6380					      struct binder_proc *proc,
  6381					      const char *prefix,
  6382					      const char *transaction_prefix,
  6383					      struct binder_work *w, bool hash_ptrs)
  6384	{
  6385		struct binder_node *node;
  6386		struct binder_transaction *t;
  6387	
  6388		switch (w->type) {
  6389		case BINDER_WORK_TRANSACTION:
  6390			t = container_of(w, struct binder_transaction, work);
  6391			print_binder_transaction_ilocked(
  6392					m, proc, transaction_prefix, t);
  6393			break;
  6394		case BINDER_WORK_RETURN_ERROR: {
  6395			struct binder_error *e = container_of(
  6396					w, struct binder_error, work);
  6397	
  6398			seq_printf(m, "%stransaction error: %u\n",
  6399				   prefix, e->cmd);
  6400		} break;
  6401		case BINDER_WORK_TRANSACTION_COMPLETE:
  6402			seq_printf(m, "%stransaction complete\n", prefix);
  6403			break;
  6404		case BINDER_WORK_NODE:
  6405			node = container_of(w, struct binder_node, work);
  6406			if (hash_ptrs)
  6407				seq_printf(m, "%snode work %d: u%p c%p\n",
  6408				   prefix, node->debug_id,
> 6409				   (void *)node->ptr, (void *)node->cookie);
  6410			else
  6411				seq_printf(m, "%snode work %d: u%016llx c%016llx\n",
  6412					   prefix, node->debug_id,
  6413					   (u64)node->ptr, (u64)node->cookie);
  6414			break;
  6415		case BINDER_WORK_DEAD_BINDER:
  6416			seq_printf(m, "%shas dead binder\n", prefix);
  6417			break;
  6418		case BINDER_WORK_DEAD_BINDER_AND_CLEAR:
  6419			seq_printf(m, "%shas cleared dead binder\n", prefix);
  6420			break;
  6421		case BINDER_WORK_CLEAR_DEATH_NOTIFICATION:
  6422			seq_printf(m, "%shas cleared death notification\n", prefix);
  6423			break;
  6424		case BINDER_WORK_FROZEN_BINDER:
  6425			seq_printf(m, "%shas frozen binder\n", prefix);
  6426			break;
  6427		case BINDER_WORK_CLEAR_FREEZE_NOTIFICATION:
  6428			seq_printf(m, "%shas cleared freeze notification\n", prefix);
  6429			break;
  6430		default:
  6431			seq_printf(m, "%sunknown work: type %d\n", prefix, w->type);
  6432			break;
  6433		}
  6434	}
  6435	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki