linux-kernel - Re: [RFC PATCH] usb: storage: Add blockbuffer ptr to info struct of sddr09 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c71aa977-d58d-4eee-9ab9-e9fbdca121bf@rowland.harvard.edu>
Date: Wed, 7 May 2025 14:29:31 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Jake Rice <jake@...erice.dev>
Cc: linux-usb@...r.kernel.org, gregkh@...uxfoundation.org,
	usb-storage@...ts.one-eyed-alien.net, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] usb: storage: Add blockbuffer ptr to info struct of
 sddr09 driver

On Tue, May 06, 2025 at 03:15:31PM -0400, Jake Rice wrote:
> Hi all,
> 
> This patch updates the sddr09 driver to allocate a reusable block
> buffer. Unfortunately, I don't have access to the SDDR-00 hardware
> (which I know is pretty ancient), so I'm requesting testing from anyone who does. 
> Please let me now if the patch causes any issues or improves performance.
> 
> Best,
> Jake
> 
> ---
> Currently, upon every write the block buffer is allocated and freed which is
> computationally expensive. With this implementation, a buffer pointer
> is added as a member to the info struct and allocated when the card
> information is read. The buffer is freed during desconstruction if
> necessary.

This isn't a high-priority sort of thing.  SDDR-09 is indeed very old 
and likely quite slow (by comparison with current hardware); the time 
required for the memory allocations and deallocations probably doesn't 
have much effect on the overall I/O rate.

Still, I guess it doesn't hurt to do this.  However, I don't have time 
to review the patch properly right now, and I don't have the hardware to 
test it with.

Alan Stern