linux-kernel - RE: [PATCH v2] dmaengine: xilinx_dma: Set dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL3PR12MB6571C982D9D8DC190414F21FC988A@BL3PR12MB6571.namprd12.prod.outlook.com>
Date: Wed, 7 May 2025 20:31:16 +0000
From: "Gupta, Suraj" <Suraj.Gupta2@....com>
To: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Vinod Koul
	<vkoul@...nel.org>, "Simek, Michal" <michal.simek@....com>, Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, "Pandey,
 Radhey Shyam" <radhey.shyam.pandey@....com>, Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>, Marek Vasut <marex@...x.de>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "Katakam, Harini"
	<harini.katakam@....com>
Subject: RE: [PATCH v2] dmaengine: xilinx_dma: Set dma_device directions

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>
> Sent: Wednesday, May 7, 2025 11:51 PM
> To: dmaengine@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; Vinod Koul <vkoul@...nel.org>; Simek, Michal
> <michal.simek@....com>; Manivannan Sadhasivam
> <manivannan.sadhasivam@...aro.org>; Uwe Kleine-König <u.kleine-
> koenig@...libre.com>; Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>;
> Pandey, Radhey Shyam <radhey.shyam.pandey@....com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org>; Marek Vasut <marex@...x.de>; linux-arm-
> kernel@...ts.infradead.org; Gupta, Suraj <Suraj.Gupta2@....com>; Katakam,
> Harini <harini.katakam@....com>
> Subject: [PATCH v2] dmaengine: xilinx_dma: Set dma_device directions
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Coalesce the direction bits from the enabled TX and/or RX channels into the
> directions bit mask of dma_device. Without this mask set,
> dma_get_slave_caps() in the DMAEngine fails, which prevents the driver from being
> used with an IIO DMAEngine buffer.
>
> Signed-off-by: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>

Reviewed-by: Suraj Gupta <suraj.gupta2@....com>
> ---
> Changes in v2:
>   - Change to Suraj's simpler version as per Radhey's request
>
>  drivers/dma/xilinx/xilinx_dma.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index
> 3ad44afd0e74..8f26b6eff3f3 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -2909,6 +2909,8 @@ static int xilinx_dma_chan_probe(struct
> xilinx_dma_device *xdev,
>                 return -EINVAL;
>         }
>
> +       xdev->common.directions |= chan->direction;
> +
>         /* Request the interrupt */
>         chan->irq = of_irq_get(node, chan->tdest);
>         if (chan->irq < 0)