linux-kernel - Re: [PATCH v2] dmaengine: xilinx_dma: Set dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D9RDE3X5FIWG.BUFCOXYYAW1U@folker-schwesinger.de>
Date: Fri, 09 May 2025 05:11:14 +0000
From: "Folker Schwesinger" <dev@...ker-schwesinger.de>
To: "Thomas Gessler" <thomas.gessler@...eckmann-gmbh.de>,
 <dmaengine@...r.kernel.org>
Cc: <linux-kernel@...r.kernel.org>, "Vinod Koul" <vkoul@...nel.org>, "Michal
 Simek" <michal.simek@....com>, "Manivannan Sadhasivam"
 <manivannan.sadhasivam@...aro.org>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, "Radhey Shyam Pandey"
 <radhey.shyam.pandey@....com>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski@...aro.org>, "Marek Vasut" <marex@...x.de>,
 <linux-arm-kernel@...ts.infradead.org>, "Suraj Gupta"
 <Suraj.Gupta2@....com>, "Harini Katakam" <harini.katakam@....com>
Subject: Re: [PATCH v2] dmaengine: xilinx_dma: Set dma_device directions

On Wed May 7, 2025 at 8:21 PM CEST, Thomas Gessler wrote:
> Coalesce the direction bits from the enabled TX and/or RX channels into
> the directions bit mask of dma_device. Without this mask set,
> dma_get_slave_caps() in the DMAEngine fails, which prevents the driver
> from being used with an IIO DMAEngine buffer.
>
> Signed-off-by: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>

Tested-by: Folker Schwesinger <dev@...ker-schwesinger.de>

> ---
> Changes in v2:
>   - Change to Suraj's simpler version as per Radhey's request
>
>  drivers/dma/xilinx/xilinx_dma.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 3ad44afd0e74..8f26b6eff3f3 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -2909,6 +2909,8 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
>  		return -EINVAL;
>  	}
>  
> +	xdev->common.directions |= chan->direction;
> +
>  	/* Request the interrupt */
>  	chan->irq = of_irq_get(node, chan->tdest);
>  	if (chan->irq < 0)