linux-kernel - Re: [PATCH 2/4] f2fs: don't return AOP_WRITEPAGE_ACTIVATE from f2fs_write_single_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250507064437.GA31135@lst.de>
Date: Wed, 7 May 2025 08:44:37 +0200
From: Christoph Hellwig <hch@....de>
To: Chao Yu <chao@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Jaegeuk Kim <jaegeuk@...nel.org>,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] f2fs: don't return AOP_WRITEPAGE_ACTIVATE from
 f2fs_write_single_data_page

On Wed, May 07, 2025 at 02:28:55PM +0800, Chao Yu wrote:
> > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> > index e016b0f96313..ce63b3bfb28f 100644
> > --- a/fs/f2fs/compress.c
> > +++ b/fs/f2fs/compress.c
> > @@ -1565,10 +1565,7 @@ static int f2fs_write_raw_pages(struct compress_ctx *cc,
> >  						NULL, NULL, wbc, io_type,
> >  						compr_blocks, false);
> >  		if (ret) {
> > -			if (ret == AOP_WRITEPAGE_ACTIVATE) {
> > -				folio_unlock(folio);
> > -				ret = 0;
> 
> Previously, for this case, it will goto out label rather than writing
> left pages?

Indeed.  Is that the right thing to do here?