linux-kernel - Re: [PATCH] regmap: remove MDIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a975df3f-45a7-426d-8e29-f3b3e2f3f9e7@gmail.com>
Date: Wed, 7 May 2025 08:49:15 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>,
 Andrew Lunn <andrew@...n.ch>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, Sander Vanheule <sander@...nheule.net>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regmap: remove MDIO support

On 07.05.2025 08:21, Mark Brown wrote:
> On Wed, May 07, 2025 at 08:09:27AM +0200, Heiner Kallweit wrote:
>> On 07.05.2025 02:50, Mark Brown wrote:
>>> On Tue, May 06, 2025 at 10:06:00PM +0200, Heiner Kallweit wrote:
> 
>>>> MDIO regmap support was added with 1f89d2fe1607 as only patch from a
>>>> series. The rest of the series wasn't applied. Therefore MDIO regmap
>>>> has never had a user.
> 
>>> Is it causing trouble, or is this just a cleanup?
> 
>> It's merely a cleanup. The only thing that otherwise would need
> 
> If it's not getting in the way I'd rather leave it there in case someone
> wants it, that way I don't need to get CCed into some other series
> again.
> 
Understood. On the other hand is has been sitting idle for 4 yrs now.

>> improvement is that REGMAP_MDIO selects MDIO_BUS w/o considering
>> the dependency of MDIO_BUS on MDIO_DEVICE. REGMAP_MDIO should
>> depend on MDIO_BUS.
> 
> Well, REGMAP_MDIO should be selected itself so none of these selects or
> dependencies would do anything anyway.